Add docker support#21
Conversation
|
I know literally nothing about Docker, lol. So I guess this is all good? @jnewland? Also, I just created a docker repo here: https://hub.docker.com/r/jonmaddox/dasher/ Could we point it at this? This pull on another of my repos has something regarding this. |
|
I was thinking about dockerizing this, and was excited to see this PR. Is there anything that can be done to help get it into dockerhub? |
| dasher: | ||
| build: . | ||
| network_mode: host | ||
| privileged: true |
There was a problem hiding this comment.
Is --privileged really necessary?
I'm running clemenstyp/dasher-docker on my system without it and it is working fine.
|
@maddox I have no experience with docker hub myself, I've only really been using docker for my own private things. ¯\_(ツ)_/¯ |
|
I have dockerhub experience! :) It's really easy to link a dockerhub repo with a github repo. I did it myself as a proof of concept with this github repo: https://hub.docker.com/r/americanwookie/rpi3-distribution/. Docker makes it really easy if your comfortable with linking your dockerhub account to your github account and giving docker several permissions. |
4 participants
👋 @maddox
So I added docker support for you. I included an example
docker-compose.ymlfile too. If you end up pushing an image up to docker hub, you'll want to change thebuild: .line toimage: maddox/dasher.One caveat: since the docker image runs as root, I skipped your setup script and instead ran the button finder directly: